Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vite ecommerce sample app #2687

Merged
merged 41 commits into from
Nov 15, 2024
Merged

Vite ecommerce sample app #2687

merged 41 commits into from
Nov 15, 2024

Conversation

svdimitr
Copy link
Contributor

@svdimitr svdimitr commented Nov 13, 2024 •
edited by filipKovachev
Loading

Related to https://github.com/telerik/kendo-react-private/issues/4360

The PR is opened so that we can deploy what we have so far. Polishing of the UI will be added in the next two days. The following discrepancies with the design can be expected:

  1. Not all buttons in the home page will lead to a specific product
  2. The "Vilora Jewelry picture" is not stretched to the full width

svdimitr and others added 30 commits October 22, 2024 14:45
@svdimitr
feat(ecommerce): initial commit for the vite ecommerce app
53f910d
@filipKovachev
add Header and Footer, add alias for imports
b0a0eb2
@filipKovachev
add a tags and spacings for the footer
248f2eb
@svdimitr
chore(components): add two components
c0f6d92
@svdimitr
add the pages folder
a7e5b62
@svdimitr
add pages
fa67032
@svdimitr
iteration over the design
756bbc2
@filipKovachev
add routing
7710a44
@svdimitr
add images
4e72103
@svdimitr
polish components
11ea905
@svdimitr
add filter
9431821
@svdimitr
extract cardlist component
f4a6a53
@svdimitr
remove outdated imports
6d3f044
@svdimitr
add detailed cat page
acef7cd
@svdimitr
polish pages, extract types
b6adcc0
@svdimitr
add the productCard compo
f2dafa4
@svdimitr
develop the app
e7f2239
@svdimitr
complete the home page
2c57c41
@svdimitr
add shopping cart
91e6f48
@filipKovachev
add payment details
fb9fddb
@filipKovachev
add button
6afdd1b
@filipKovachev
add Thank you page
bbcf1e7
@svdimitr
shopping cart
d0c1623
@svdimitr
link navigation
490c8b0
@svdimitr
add primary btns
6329826
@svdimitr
polish shopping cart
08c2cb2
@svdimitr
polish shopping cart
db61825
@svdimitr
final polish:
9f30686
@svdimitr
fix build errors
f89b19c
@svdimitr
fix build errors
fcfba30
PaskalevStoyan
PaskalevStoyan requested changes Nov 13, 2024
View reviewed changes
examples/ecommerce-jewellery-store/src/components/CardsList.tsx Outdated Show resolved Hide resolved
examples/ecommerce-jewellery-store/src/components/CategoryList.tsx Outdated Show resolved Hide resolved
examples/ecommerce-jewellery-store/src/components/ExpiryDate.tsx Show resolved Hide resolved
examples/ecommerce-jewellery-store/src/components/ShoppingCartList.tsx Outdated Show resolved Hide resolved
examples/ecommerce-jewellery-store/src/components/ShoppingCartList.tsx Outdated
return (
<div
className="k-d-flex k-gap-5 k-justify-content-center k-border-y k-align-items-center k-pb-5"
key={isCartItem ? item.product.id : null}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will result in children having duplicated unique keys and this is bad because components with same keys may cause children to be duplicated and/or omitted. Please reconsider using the index of each child as unique key -> something like: cart-item-${index}

examples/ecommerce-jewellery-store/src/components/Testemonials.tsx Show resolved Hide resolved
@bptodorova
Copy link
Contributor

Make sure the following commands pass.

cd examples/ecommerce-jewellery-store
npm ci
npm run build

  • Currently npm ci says that there is divergency in package.json and package-lock.json

  • If I run npm i instead of npm ci and after that
    npm run build it fails with
    error TS17004: Cannot use JSX unless the '--jsx' flag is provided.

@svdimitr
Copy link
Contributor Author

Make sure the following commands pass.

cd examples/ecommerce-jewellery-store
npm ci
npm run build
  • Currently npm ci says that there is divergency in package.json and package-lock.json
  • If I run npm i instead of npm ci and after that
    npm run build it fails with
    error TS17004: Cannot use JSX unless the '--jsx' flag is provided.

The npm ci command is fixed along with the --jsx flag. There are some build errors that were caused here 2ab47f8 and we are fixing

@filipKovachev
Update README.md
498cc97 
update README with available commands
@svdimitr svdimitr merged commit dc5b438 into master Nov 15, 2024
2 checks passed
@svdimitr svdimitr deleted the vite-ecommerce-sample-app branch November 15, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bptodorova bptodorova bptodorova approved these changes

@filipKovachev filipKovachev filipKovachev approved these changes

@PaskalevStoyan PaskalevStoyan PaskalevStoyan approved these changes

@elena-gancheva elena-gancheva Awaiting requested review from elena-gancheva

Assignees

@svdimitr svdimitr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@svdimitr @bptodorova @PaskalevStoyan @filipKovachev